Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.nicolive: fix email logins #4553

Merged
merged 1 commit into from May 28, 2022

Conversation

bastimeyer
Copy link
Member

fixes #4539

The user_session cookie already gets set in certain regions, so there's no need to check for a confirmation code.

Tested with local German IP and Japanese proxy, using a fresh account.


@cddb222 could you please confirm that this is working for you?

Download the plugin file and sideload it
https://streamlink.github.io/cli/plugin-sideloading.html

https://raw.githubusercontent.com/bastimeyer/streamlink/958c42e028160cfdb7f2bedc9cfced414ac63000/src/streamlink/plugins/nicolive.py

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label May 27, 2022
@bastimeyer bastimeyer requested a review from back-to May 27, 2022 15:44
@back-to back-to merged commit 42f1112 into streamlink:master May 28, 2022
@bastimeyer bastimeyer deleted the plugins/nicolive/fix-logins branch May 28, 2022 07:41
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request May 28, 2022
Billy2011 added a commit to Billy2011/streamlink-27 that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin issue A Plugin does not work correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plugins.nicolive: Niconico login broken (404)
3 participants